add Release version as an optional field in the CSV#454
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
grokspawn
force-pushed
the
release-version
branch
from
9966937 to
e9857af
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 37.71% 37.78% +0.07%
==========================================
Files 56 57 +1
Lines 4516 4557 +41
==========================================
+ Hits 1703 1722 +19
- Misses 2661 2678 +17
- Partials 152 157 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grokspawn
force-pushed
the
release-version
branch
4 times, most recently
from
f8bf7e2 to
bddcea6
Compare
|
Respects the legacy ability to encode a release version implicitly in semver build metadata when adding a bundle-level Before: ./bin/opm render registry.redhat.io/amq7/amq-broker-rhel8-operator-bundle@sha256:ce274a661f64f3b872b69f2c5b6f6c93f841f456037f69b813ede777c944489b -o yaml | yq 'select(.schema == "olm.bundle").properties[]| select(.type == "olm.package")'type: olm.package
value:
packageName: amq-broker-rhel8
version: 7.10.2-opr-2+0.1676475747.pAfter: ./bin/opm render registry.redhat.io/amq7/amq-broker-rhel8-operator-bundle@sha256:ce274a661f64f3b872b69f2c5b6f6c93f841f456037f69b813ede777c944489b -o yaml | yq 'select(.schema == "olm.bundle").properties[]| select(.type == "olm.package")'type: olm.package
value:
packageName: amq-broker-rhel8
release: 0.1676475747.p
version: 7.10.2-opr-2 |
Signed-off-by: grokspawn <[email protected]> Assisted-by: claude
grokspawn
force-pushed
the
release-version
branch
from
bddcea6 to
7db47d7
Compare
grokspawn
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
I'm clearing the WIP because I'm hoping to get some reviews/eyes here, but I'm putting on a hold because we want to control the sequence of merges for this and related PRs. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Want to note here that all the off- and on-cluster tooling in o-f and known derivatives is set to unmarshal with tolerance for unknown fields, so the use of this feature with old tooling will result in the field getting dropped/ignored, not a functional impact. |
|
/hold cancel opening the floodgates to reviewers ;) |
openshift-ci
bot
removed
the
do-not-merge/hold
rashmigottipati
left a comment
rashmigottipati
left a comment
There was a problem hiding this comment.
Not super clear behind the motivations for this PR, but changes look good overall.
One question I have is: currently I dont think this would reject invalid release strings. What do you think about adding validation to ensure semver correctness?
|
cc |
grokspawn
force-pushed
the
release-version
branch
3 times, most recently
from
78e27ed to
663bbcc
Compare
grokspawn
force-pushed
the
release-version
branch
from
663bbcc to
4f11d6e
Compare
grokspawn
force-pushed
the
release-version
branch
from
4f11d6e to
4a61e98
Compare
|
/approve |
openshift-ci
bot
added
the
approved
Signed-off-by: grokspawn <[email protected]>
grokspawn
force-pushed
the
release-version
branch
from
4a61e98 to
9984aa0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f65ea7e
into
operator-framework:master
7 participants
As part of the epic, in order for bundle authors to be able to specify release information, it must be part of the CSV.
This PR proposes an optional additional
releasefield which expresses this information, enabling its use in the catalog creation / consumption flows both on- and off-cluster.Now with a bonus bundle manifest validator to enforce the release version bundle naming convention, which is used by the operator-verify tool.